public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Make ON_ERROR_STOP stop on shell script failure
Date: Tue, 27 Sep 2022 12:34:25 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

At Wed, 21 Sep 2022 11:45:07 +0900, Fujii Masao <[email protected]> wrote in 
> 
> 
> On 2022/09/20 15:15, bt22nakamorit wrote:
> >>>> I thought that this action is rather unexpected since, based on the
> >>>> word """ON_ERROR_STOP""", ones may expect that failures of shell
> >>>> scripts should halt the incoming instructions as well.
> >>>> One clear solution is to let failures of shell script stop incoming
> >>>> queries just like how errors of SQLs do currently. Thoughts?
> 
> +1
> 
> 
> > I edited the documentation for ON_ERROR_STOP.
> > Any other suggestions?
> 
> Thanks for the patch!
> Could you add it to the next CommitFest so that we don't forget it?
> 
> 
> We can execute the shell commands via psql in various ways
> other than \! meta-command. For example,
> 
> * `command`
> * \g | command
> * \gx | command
> * \o | command
> * \w | command
> * \copy ... program 'command'
> 
> ON_ERROR_STOP should handle not only \! but also all the above in the
> same way?

+1

> One concern about this patch is that some applications already depend
> on
> the current behavior of ON_ERROR_STOP, i.e., psql doesn't stop even
> when
> the shell command returns non-zero exit code. If so, we might need to
> extend ON_ERROR_STOP so that it accepts the following setting values.
> 
> * off - don't stop even when either sql or shell fails (same as the
> * current behavior)
> * on or sql - stop only whensql fails (same as the current behavior)
> * shell - stop only when shell fails
> * all - stop when either sql or shell fails
> 
> Thought?

+1

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

view thread (20+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Make ON_ERROR_STOP stop on shell script failure
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox