From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: wangw.fnst@fujitsu.com <wangw.fnst@fujitsu.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: samay sharma <smilingsamay@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [RFC] building postgres with meson - v13
Date: Sun, 2 Oct 2022 12:25:20 -0500
Message-ID: <20221002172520.GC7745@telsasoft.com> (raw)
In-Reply-To: <20220927011951.j3h4o7n6bhf7dwau@awork3.anarazel.de>
References: <20220922150550.pscsjv4nwnslupeg@awork3.anarazel.de>
<20220922200533.GA697326@nathanxps13>
<20220922202809.4touie37lfafyabw@awork3.anarazel.de>
<20220922223729.GA721620@nathanxps13>
<2298281.1664041949@sss.pgh.pa.us>
<20220924180955.2hevwoniwsj2q2tm@awork3.anarazel.de>
<c5736f70-bb6d-8d25-e35c-e3d886e4e905@enterprisedb.com>
<20220926163516.ftxjmoljjwyy4m2q@awork3.anarazel.de>
<20220926194435.4hhrwu7d6anrapc3@awork3.anarazel.de>
<20220927011951.j3h4o7n6bhf7dwau@awork3.anarazel.de>
On Mon, Sep 26, 2022 at 06:19:51PM -0700, Andres Freund wrote:
> From 680ff3f7b4da1dbf21d0c7cd87af9bb5ee8b230c Mon Sep 17 00:00:00 2001
> From: Andres Freund <andres@anarazel.de>
> Date: Wed, 21 Sep 2022 20:36:36 -0700
> Subject: [PATCH v17 01/23] meson: ci: wip: move compilerwarnings task to meson
This patch isn't finished, but this part looks like a rebase conflict:
- make -s -j${BUILD_JOBS} clean
+ make -s -j${BUILD_JOBS} world-bin
Also, you wrote "rm -fr build" between building for gcc and clang, but
since they run in an "always" block, it'd be better to use separate
dirs, to allow seeing logs for the the all (failed) tasks, in case the
last one succeeds.
On Mon, Sep 26, 2022 at 06:19:51PM -0700, Andres Freund wrote:
> From 6025cb80d65fd7a8414241931df9f003a292052f Mon Sep 17 00:00:00 2001
> From: Andres Freund <andres@anarazel.de>
> Date: Sun, 25 Sep 2022 12:07:29 -0700
> Subject: [PATCH v17 16/23] windows: adjust FD_SETSIZE via commandline
> define
> +++ b/src/bin/pgbench/meson.build
> @@ -27,6 +27,8 @@ pgbench = executable('pgbench',
> pgbench_sources,
> dependencies: [frontend_code, libpq, thread_dep],
> include_directories: include_directories('.'),
> + c_pch: pch_postgres_fe_h,
> + c_args: host_system == 'windows' ? ['-DFD_SETSIZE=1024'] : [],
> kwargs: default_bin_args,
> )
This puts PCH into the preparatory commit.
Also, src/tools/msvc/Mkvcbuild.pm seems to use spaces rather than tabs.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, andres@anarazel.de, peter.eisentraut@enterprisedb.com, pg@bowt.ie, wangw.fnst@fujitsu.com, tgl@sss.pgh.pa.us, nathandbossart@gmail.com, andrew@dunslane.net, thomas.munro@gmail.com, smilingsamay@gmail.com, byavuz81@gmail.com
Subject: Re: [RFC] building postgres with meson - v13
In-Reply-To: <20221002172520.GC7745@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox