From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Joe Conway <mail@joeconway.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Joshua Brindle <joshua.brindle@crunchydata.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: use has_privs_of_role() for pg_hba.conf
Date: Sat, 8 Oct 2022 10:06:40 -0700
Message-ID: <20221008170640.GA825354@nathanxps13> (raw)
In-Reply-To: <CA+TgmoYDUpotJ3R5cPWqKZpi7TmTRq2ud4OYsvWnvPYK0KmaAQ@mail.gmail.com>
References: <20221006174343.GA444656@nathanxps13>
<Yz+Jt9537vjfO733@paquier.xyz>
<20221007032711.GA499771@nathanxps13>
<Yz/Ii6dr1CSu4Bnv@paquier.xyz>
<20221007194430.GA550749@nathanxps13>
<3347532.1665173939@sss.pgh.pa.us>
<20221007215836.GB814385@nathanxps13>
<87994809-5b2c-08f0-0ab3-3c76c49afada@joeconway.com>
<3574712.1665242046@sss.pgh.pa.us>
<CA+TgmoYDUpotJ3R5cPWqKZpi7TmTRq2ud4OYsvWnvPYK0KmaAQ@mail.gmail.com>
On Sat, Oct 08, 2022 at 11:46:50AM -0400, Robert Haas wrote:
> Now there may be some other scenario in which the patch is going in
> exactly the right direction, and if I knew what it was, maybe I'd
> agree that the patch was a great idea. But I haven't seen anything
> like that on the thread. Basically, the argument is just that the
> change would make things more consistent. However, it might be an
> abuse of the term. If you go out and buy blue curtains because you
> have a blue couch, that's consistent interior decor. If you go out and
> buy a blue car because you have a blue couch, that's not really
> consistent anything, it's just two fairly-unrelated things that are
> both blue.
I believe I started this thread after reviewing the remaining uses of
is_member_of_role() after 6198420 was committed and wondering whether this
case was an oversight. If upon closer inspection we think that mere
membership is appropriate for pg_hba.conf, I'm fully prepared to go and
mark this commitfest entry as Rejected. It obviously does not seem as
clear-cut as 6198420. And I'll admit I don't have a concrete use-case in
hand to justify the behavior change.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, mail@joeconway.com, michael@paquier.xyz, joshua.brindle@crunchydata.com
Subject: Re: use has_privs_of_role() for pg_hba.conf
In-Reply-To: <20221008170640.GA825354@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox