From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: bharath.rupireddyforpostgres@gmail.com
Cc: tgl@sss.pgh.pa.us
Cc: peter.eisentraut@enterprisedb.com
Cc: benoit.lobreau@gmail.com
Cc: alvherre@alvh.no-ip.org
Cc: robertmhaas@gmail.com
Cc: bossartn@amazon.com
Cc: david@pgmasters.net
Cc: masao.fujii@oss.nttdata.com
Cc: pgsql-hackers@postgresql.org
Cc: magnus@hagander.net
Cc: sfrost@snowman.net
Subject: Re: archive modules
Date: Sat, 5 Nov 2022 14:08:58 -0700
Message-ID: <20221105210858.GB137360@nathanxps13> (raw)
In-Reply-To: <Y0zs/wst7XY8rFbW@paquier.xyz>
References: <CALj2ACXYQckdBWQTpJDCRd9r7xxJsdnbuHp-DnNEAWpiPZwtfA@mail.gmail.com>
<20221014185130.GC1678424@nathanxps13>
<20221014214256.GA1819154@nathanxps13>
<20221017.134639.1811443236787336786.horikyota.ntt@gmail.com>
<Y0zs/wst7XY8rFbW@paquier.xyz>
On Mon, Oct 17, 2022 at 02:49:51PM +0900, Michael Paquier wrote:
> And, by the way, this patch would prevent the existence of archive
> modules that need to be loaded but *want* an archive_command with
> what they want to achieve. That does not strike me as a good idea if
> we want to have a maximum of flexibility with this facility.
Such a module could define a custom GUC that accepts a shell command. I
don't think we should overload the meaning of archive_command based on the
whims of whatever archive module is loaded. Besides the potential end-user
confusion, your archive_command might be unexpectedly used incorrectly if
you forget to set archive_library.
Perhaps we could eventually move the archive_command functionality to a
contrib module (i.e., "shell_archive") so that users must always set
archive_library. But until then, I suspect it's better to treat modules
and commands as two separate interfaces to ease migration from older major
versions (even though archive_command is now essentially a built-in archive
module).
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, michael@paquier.xyz, horikyota.ntt@gmail.com, bharath.rupireddyforpostgres@gmail.com, tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, benoit.lobreau@gmail.com, alvherre@alvh.no-ip.org, robertmhaas@gmail.com, bossartn@amazon.com, david@pgmasters.net, masao.fujii@oss.nttdata.com, magnus@hagander.net, sfrost@snowman.net
Subject: Re: archive modules
In-Reply-To: <20221105210858.GB137360@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox