public inbox for [email protected]
help / color / mirror / Atom feedFrom: Justin Pryzby <[email protected]>
To: David Christensen <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: Ian Lawrence Barwick <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Date: Fri, 11 Nov 2022 08:15:04 -0600
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAOxo6X+t9BfKLJ0FSC2fOHNh8icOZ=LBmrkm1HxRmZuLxLjLUg@mail.gmail.com>
References: <[email protected]>
<CAOxo6X+2-k6gqwv2okbgLR_B_MkBCVHOW3CqFomFta2wNkHYdw@mail.gmail.com>
<CAOxo6XJt=F3eKS8-jvFYoW2MVP+DCpseHPHYiLVYGF43iET30Q@mail.gmail.com>
<[email protected]>
<CAOxo6XJ_pf+cKDXZMvxprvA1x-Pi+-22fq0Tw50o9HgkXg7cTw@mail.gmail.com>
<CAOxo6XLCwGGjLEK9--VK9SzOb4EFKiJuSrnOePSPfEyr-pLKPw@mail.gmail.com>
<CALj2ACWU7ckJLu=9Ag0AahnWT=1E22FsPu9wmcyAEJCv04BCvA@mail.gmail.com>
<[email protected]>
<CAOxo6X+_bSFwsCwMOdxcUV9Hf-FMtHt9fgTLYsbJQgFrXXpqNA@mail.gmail.com>
<CAOxo6X+t9BfKLJ0FSC2fOHNh8icOZ=LBmrkm1HxRmZuLxLjLUg@mail.gmail.com>
On Wed, Nov 09, 2022 at 02:37:29PM -0600, David Christensen wrote:
> On Wed, Nov 9, 2022 at 2:08 PM David Christensen <[email protected]> wrote:
> > Justin sez:
> > > I was wondering if there's any reason to do "CREATE DATABASE". The vast
> > > majority of TAP tests don't.
> > >
> > > $ git grep -ho 'safe_psql[^ ]*' '*pl' |sort |uniq -c |sort -nr |head
> > > 1435 safe_psql('postgres',
> > > 335 safe_psql(
> > > 23 safe_psql($connect_db,
> >
> > If there was a reason, I don't recall offhand; I will test removing it
> > and if things still work will consider it good enough.
>
> Things blew up when I did that; rather than hunt it down, I just left it in. :-)
> +$primary->safe_psql('db1', <<EOF);
It worked for me when I removed the 3 references to db1.
That's good for efficiency of the test.
> +my $blocksize = 8192;
I think this should be just "my $blocksize;" rather than setting a value
which is later overwriten.
--
Justin
view thread (57+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox