public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: Justin Pryzby <[email protected]>
Cc: [email protected]
Subject: Re: fix and document CLUSTER privileges
Date: Wed, 7 Dec 2022 20:13:13 -0800
Message-ID: <20221208041313.GA216874@nathanxps13> (raw)
In-Reply-To: <[email protected]>
References: <20221207223924.GA4182184@nathanxps13>
<[email protected]>
On Wed, Dec 07, 2022 at 08:25:59PM -0600, Justin Pryzby wrote:
> Your patch makes it inconsistent with vacuum full, which is strange
> because vacuum full calls cluster.
>
> postgres=> VACUUM FULL t;
> VACUUM
> postgres=> CLUSTER t;
> ERROR: must be owner of table t
This is the existing behavior on HEAD. I think it has been this way for a
while. Granted, that doesn't mean it's ideal, but AFAICT it's intentional.
Looking closer, the database ownership check in
get_tables_to_cluster_partitioned() appears to have no meaningful effect.
In this code path, cluster_rel() will always be called with CLUOPT_RECHECK,
and that function only checks for table ownership. Anything gathered in
get_tables_to_cluster_partitioned() that the user doesn't own will be
skipped. So, I don't think my patch changes the behavior in any meaningful
way, but I still think it's worthwhile to make the checks consistent.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: fix and document CLUSTER privileges
In-Reply-To: <20221208041313.GA216874@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox