From: Nathan Bossart <nathandbossart@gmail.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Rework confusing permissions for LOCK TABLE
Date: Wed, 14 Dec 2022 09:23:15 -0800
Message-ID: <20221214172315.GA689830@nathanxps13> (raw)
In-Reply-To: <9550c76535404a83156252b25a11babb4792ea1e.camel@j-davis.com>
References: <9550c76535404a83156252b25a11babb4792ea1e.camel@j-davis.com>
On Tue, Dec 13, 2022 at 06:59:48PM -0800, Jeff Davis wrote:
> I can't think of any reason for this behavior, and I didn't find an
> obvious answer in the last commits to touch that (2ad36c4e44,
> fa2642438f).
I can't think of a reason, either.
> Patch attached to simplify it. It uses the philosophy that, if you have
> permissions to lock at a given mode, you should be able to lock at
> strictly less-conflicting modes as well.
+1. Your patch looks reasonable to me.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, pgsql@j-davis.com
Subject: Re: Rework confusing permissions for LOCK TABLE
In-Reply-To: <20221214172315.GA689830@nathanxps13>
References: <9550c76535404a83156252b25a11babb4792ea1e.camel@j-davis.com> <20221214172315.GA689830@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox