pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Pavel Luzanov <p.luzanov@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Subject: Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX
Date: Thu, 15 Dec 2022 11:12:46 -0800
Message-ID: <20221215191246.GA252861@nathanxps13> (raw)
In-Reply-To: <8f63ff5b9188004c8e439ac16e92adf3266169b9.camel@j-davis.com>
References: <20221214171336.GB689106@nathanxps13>
	<20221214180534.jglo7jclow3x73bd@alvherre.pgsql>
	<20221214181659.GB773264@nathanxps13>
	<efd049fb7407c5eb0cc3212e7ea43bebf48eab0f.camel@j-davis.com>
	<20221214232939.GA828727@nathanxps13>
	<Y5pmaksAYyJbSU77@paquier.xyz>
	<20221215002705.GA889413@nathanxps13>
	<8f63ff5b9188004c8e439ac16e92adf3266169b9.camel@j-davis.com>

On Thu, Dec 15, 2022 at 10:42:15AM -0800, Jeff Davis wrote:
> Right now, targetting the toast table directly requires the USAGE
> privilege on the toast schema, and you have to look up the name first,
> right? As it is, that's not a great UI.
> 
> How about if we add a VACUUM option like TOAST_ONLY (or combine it with
> the PROCESS_TOAST option)? Then, you're always looking at the parent
> table first so there's no deadlock, do the permission checks on the
> parent, and then expand to the toast table with no check. This can be a
> follow-up patch; for now, the idea of skipping the privilege checks
> when expanding looks like an improvement.

I originally suggested an option to allow specifying whether to process the
main relation, but we ended up only adding PROCESS_TOAST [0].  FWIW I still
think that such an option would be useful for the reasons you describe.

[0] https://postgr.es/m/BA8951E9-1524-48C5-94AF-73B1F0D7857F%40amazon.com

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (79+ messages)  latest in thread

Message-ID: <20221215191246.GA252861@nathanxps13>
Permalink:  ../20221215191246.GA252861@nathanxps13/
Also on:    postgresql.org/message-id/20221215191246.GA252861@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, pgsql@j-davis.com, michael@paquier.xyz, alvherre@alvh.no-ip.org, p.luzanov@postgrespro.ru
  Subject: Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX
  In-Reply-To: <20221215191246.GA252861@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox