public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andres Freund <[email protected]>
To: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: [email protected]
Cc: David Rowley <[email protected]>
Cc: Dagfinn Ilmari Mannsåker <[email protected]>
Subject: Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local
Date: Wed, 28 Dec 2022 16:02:23 -0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
On 2022-12-28 13:43:27 -0500, Tom Lane wrote:
> > In the compiler test, I chose to not check whether -Werror=unknown-pragmas is
> > supported - it appears to be an old gcc flag, and the worst outcome is that
> > HAVE_PRAGMA_SYSTEM_HEADER isn't defined.
> > We could alternatively define HAVE_PRAGMA_SYSTEM_HEADER or such based on
> > __GNUC__ being defined.
>
> Hmm ... I guess the buildfarm would tell us whether that detection works
> correctly on platforms where it matters. Let's keep it simple if we
> can.
Quick clarification question: Are you suggesting to use #ifdef __GNUC__, or
that it suffices to use -Werror=unknown-pragmas without a separate configure
check?
view thread (13+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox