public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: [email protected]
Cc: David Rowley <[email protected]>
Cc: Dagfinn Ilmari Mannsåker <[email protected]>
Subject: Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local
Date: Thu, 29 Dec 2022 13:40:13 -0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Hi,

On 2022-12-29 13:51:37 -0500, Tom Lane wrote:
> We might find that some GCC-impostor compilers have trouble with it,
> but if so we can adjust the #ifdef here.

Yea. I suspect it's widely enough used that any compiler claiming to be gcc
compatible has it, but ...


> Getting nitpicky, I suggest calling it "HAVE_PRAGMA_GCC_SYSTEM_HEADER"
> to align better with what you actually have to write.

Makes sense.


> + * Newer versions the perl headers trigger a lot of warnings with our compiler
> 
> "Newer versions of ..." please.  Otherwise LGTM.

Oops.


> > Should we backpatch this? Given the volume of warnings it's probably a good
> > idea. But I'd let it step in HEAD for a few days of buildfarm coverage first.
> 
> +1 to both points.

Pushed to HEAD.

Greetings,

Andres Freund

view thread (13+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox