public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: mprove tab completion for ALTER EXTENSION ADD/DROP
Date: Wed, 11 Jan 2023 12:10:33 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALDaNm3s0MHr1iw716JsacmA4yyCFn4tCw1=3c6Sm2xjvBVYDA@mail.gmail.com>
References: <GaJE0VEMyKS42oPVKkRIwUHOG3VUfJCP_0Qb3ZcnetGLbTXmcgMqioYUL2H_3mIgIpZgRqBq1MTHY-WohgYqxDeD7D8Q8lWXTrfh1bcJHI0=@pm.me>
	<Y41H/[email protected]>
	<CALDaNm3s0MHr1iw716JsacmA4yyCFn4tCw1=3c6Sm2xjvBVYDA@mail.gmail.com>

At Mon, 2 Jan 2023 13:19:50 +0530, vignesh C <[email protected]> wrote in 
> On Mon, 5 Dec 2022 at 06:53, Michael Paquier <[email protected]> wrote:
> >
> > The DROP could be matched with the objects that are actually part of
> > the so-said extension?
> 
> The modified v2 version has the changes to handle the same. Sorry for
> the delay as I was working on another project.

It suggests the *kinds* of objects that are part of the extension, but
lists the objects of that kind regardless of dependency.  I read
Michael suggested (and I agree) to restrict the objects (not kinds) to
actually be a part of the extension. (And not for object kinds.)

However I'm not sure it is useful to restrict object kinds since the
operator already knows what to drop, if you still want to do that, the
use of completion_dont_quote looks ugly since the function
(requote_identifier) is assuming an identifier as input.  I didn't
looked closer but maybe we need another way to do that.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: mprove tab completion for ALTER EXTENSION ADD/DROP
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox