From: Justin Pryzby <pryzby@telsasoft.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: Progress report of CREATE INDEX for nested partitioned tables
Date: Wed, 18 Jan 2023 09:25:35 -0600
Message-ID: <20230118152535.GZ9837@telsasoft.com> (raw)
In-Reply-To: <20230117205904.GW9837@telsasoft.com>
References: <039564d234fc3d014c555a7ee98be69a9e724836.camel@gmail.com>
<20221217143002.GR1153@telsasoft.com>
<20230108164849.GA21731@telsasoft.com>
<865a4ff239b6824fd5bbdd4a972390d1e95144b4.camel@gmail.com>
<31ee17da-8705-9afc-9451-5374a5e51aff@enterprisedb.com>
<20230117205904.GW9837@telsasoft.com>
TBH, I think the best approach is what I did in:
0001-report-top-parent-progress-for-CREATE-INDEX.txt
That's a minimal patch, ideal for backpatching.
..which defines/clarifies that the progress reporting is only for
*direct* children. That avoids the need to change any data structures,
and it's what was probably intended by the original patch, which doesn't
seem to have considered intermediate partitioned tables.
I think it'd be fine to re-define that in some future release, to allow
showing indirect children (probably only "leaves", and not intermediate
partitioned tables). Or "total_bytes" or other global progress.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, tomas.vondra@enterprisedb.com, ilya.v.gladyshev@gmail.com, alvherre@alvh.no-ip.org
Subject: Re: Progress report of CREATE INDEX for nested partitioned tables
In-Reply-To: <20230118152535.GZ9837@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox