public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Thomas Munro <[email protected]>
Cc: [email protected]
Cc: Robert Haas <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Subject: Re: postgres_fdw uninterruptible during connection establishment / ProcSignalBarrier
Date: Mon, 23 Jan 2023 19:28:06 -0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+hUKGKumpwy+_Zx9_dshccF2HYKqwMCbeeSoOFXy+9ntsh54Q@mail.gmail.com>
	<[email protected]>
	<CA+hUKG+pZkPAag-KqSCDKcuUv03yBtKk0p-i662VbHi_Jzuyhw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CA+hUKGLTngoe7NAWAOUut2p9uiWCKhvLfbaFJJi4p+QXeEZQ7A@mail.gmail.com>
	<[email protected]>

Hi,

On 2023-01-20 19:00:08 -0800, Andres Freund wrote:
> Updated patch attached. I split it into multiple pieces.
> 1) A fix for [1], included here because I encountered it while testing
> 2) Introduction of libpq-be-fe-helpers.h
> 3) Convert dblink and postgres_fdw to the helper
> 4) Convert libpqwalreceiver.c to the helper
> 
> Even if we eventually decide to backpatch 3), we'd likely not backpatch 4), as
> there's no bug (although perhaps the lack of FD handling could be called a
> bug?).
> 
> There's also some light polishing, improving commit message, comments and
> moving some internal helper functions to later in the file.

After a tiny bit further polishing, and after separately pushing a resource
leak fix for walrcv_connect(), I pushed this.

Greetings,

Andres Freund

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: postgres_fdw uninterruptible during connection establishment / ProcSignalBarrier
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox