pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Karl O. Pinc <kop@karlpinc.com>
To: Devrim Gündüz <devrim@gunduz.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Joe Conway <mail@joeconway.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: drop postmaster symlink
Date: Wed, 25 Jan 2023 18:03:25 -0600
Message-ID: <20230125180325.696f2cd7@slate.karlpinc.com> (raw)
In-Reply-To: <f6c7bdd1102e9f8b1013a2d4a4552759a695b900.camel@gunduz.org>
References: <ece84b69-8f94-8b88-925f-64207cb3a2f0@enterprisedb.com>
	<252b8b14-dc3e-1c70-3da5-e59c1616f2ad@joeconway.com>
	<6b11c9efcd3a1d89719370224d84f8cd5e7b1a8c.camel@gunduz.org>
	<3705500.1669216069@sss.pgh.pa.us>
	<20221123195010.huuypoilx6lw7ceg@awork3.anarazel.de>
	<CA+TgmoZdJ3TOBCnoz0x0zzfOtbOR12f1PHLQP8G1U3NEycUgRw@mail.gmail.com>
	<61846051-90b9-adb6-7627-08a374473a61@joeconway.com>
	<63a898b5-dc09-1ec1-40ec-e9d09e8304e7@enterprisedb.com>
	<b46cb741-7856-2410-0c4f-2af9e0fb9892@joeconway.com>
	<05cd2e78dd3b7142f16fd7f14b1694c3520af345.camel@gunduz.org>
	<7165e051-94c7-4e14-ff0a-043b34c67e9e@enterprisedb.com>
	<f6c7bdd1102e9f8b1013a2d4a4552759a695b900.camel@gunduz.org>

Hello,

Somehow I missed the email changing the status of this back
to "needs review".

Buried in
https://www.postgresql.org/message-id/20230107165942.748ccf4e%40slate.karlpinc.com
is the one change I see that should be made.

> In doc/src/sgml/ref/allfiles.sgml at line 222 there is an ENTITY
> defined which references the deleted postmaster.sgml file.

This line needs to be removed and the
0002-Don-t-install-postmaster-symlink-anymore.patch 
updated.  (Unless there's some magic going on
with the various allfiles.sgml files of which I am
not aware.)

If this is fixed I see no other problems.

Regards,

Karl <kop@karlpinc.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein





view thread (27+ messages)  latest in thread

Message-ID: <20230125180325.696f2cd7@slate.karlpinc.com>
Permalink:  ../20230125180325.696f2cd7@slate.karlpinc.com/
Also on:    postgresql.org/message-id/20230125180325.696f2cd7@slate.karlpinc.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: kop@karlpinc.com, devrim@gunduz.org, peter.eisentraut@enterprisedb.com, mail@joeconway.com, robertmhaas@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us
  Subject: Re: drop postmaster symlink
  In-Reply-To: <20230125180325.696f2cd7@slate.karlpinc.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox