pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Fujii Masao <fujii@postgresql.org>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Weird failure with latches in curculio on v15
Date: Sat, 4 Feb 2023 10:03:54 -0800
Message-ID: <20230204180354.GA258107@nathanxps13> (raw)
In-Reply-To: <20230204113029.xlcqrbxhp6lerrnc@alap3.anarazel.de>
References: <Y9nGDSgIm83FHcad@paquier.xyz>
	<20230201021206.wobi3dsnnuany3yq@alap3.anarazel.de>
	<CA+hUKGKf9Bgik=g1yPQ-crSuuziyFsScnbauG50O5328TKV1rA@mail.gmail.com>
	<20230201105514.rsjl4bnhb65giyvo@alap3.anarazel.de>
	<1369666.1675264346@sss.pgh.pa.us>
	<20230201165801.33ydbxvjdbomjqa7@alap3.anarazel.de>
	<20230201175806.GA3199959@nathanxps13>
	<20230201223555.GA3721373@nathanxps13>
	<Y9sam108o4mxZFiS@paquier.xyz>
	<20230204113029.xlcqrbxhp6lerrnc@alap3.anarazel.de>

On Sat, Feb 04, 2023 at 03:30:29AM -0800, Andres Freund wrote:
> That's kind of my problem with these changes. They try to introduce new
> abstraction layers, but don't provide real abstraction, because they're
> very tightly bound to the way the functions were called before the
> refactoring.  And none of these restrictions are actually documented.

Okay.  Michael, why don't we revert the shell_restore stuff for now?  Once
the archive modules interface changes and the fix for this
SIGTERM-during-system() problem are in, I will work through this feedback
and give recovery modules another try.  I'm still hoping to have recovery
modules ready in time for the v16 feature freeze.

My intent was to improve this code by refactoring and reducing code
duplication, but I seem to have missed the mark.  I am sorry.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (78+ messages)  latest in thread

Message-ID: <20230204180354.GA258107@nathanxps13>
Permalink:  ../20230204180354.GA258107@nathanxps13/
Also on:    postgresql.org/message-id/20230204180354.GA258107@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, andres@anarazel.de, michael@paquier.xyz, tgl@sss.pgh.pa.us, thomas.munro@gmail.com, fujii@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: Weird failure with latches in curculio on v15
  In-Reply-To: <20230204180354.GA258107@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox