From: Nathan Bossart <nathandbossart@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: thomas.munro@gmail.com
Cc: tgl@sss.pgh.pa.us
Cc: john.naylor@enterprisedb.com
Cc: noriyoshi.shinoda@hpe.com
Cc: jchampion@timescale.com
Cc: sawada.mshk@gmail.com
Cc: masao.fujii@oss.nttdata.com
Cc: pgsql-hackers@postgresql.org
Cc: rjuju123@gmail.com
Subject: Re: Improve logging when using Huge Pages
Date: Thu, 9 Feb 2023 11:29:09 -0800
Message-ID: <20230209192909.GA606606@nathanxps13> (raw)
In-Reply-To: <20230209094013.67varf63bihops33@alvherre.pgsql>
References: <20230208231803.GP1653@telsasoft.com>
<20230209094013.67varf63bihops33@alvherre.pgsql>
On Thu, Feb 09, 2023 at 10:40:13AM +0100, Alvaro Herrera wrote:
> On 2023-Feb-08, Justin Pryzby wrote:
>> I don't think it makes sense to run postgres -C huge_pages_active,
>> however, so I see no issue that that would always returns "false".
>
> Hmm, I would initialize it to return "unknown" rather than "off" — and
> make sure it turns "off" at the appropriate time. Otherwise you're just
> moving the confusion elsewhere.
I think this approach would address my concerns about using a GUC.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, alvherre@alvh.no-ip.org, pryzby@telsasoft.com, andres@anarazel.de, michael@paquier.xyz, horikyota.ntt@gmail.com, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, john.naylor@enterprisedb.com, noriyoshi.shinoda@hpe.com, jchampion@timescale.com, sawada.mshk@gmail.com, masao.fujii@oss.nttdata.com, rjuju123@gmail.com
Subject: Re: Improve logging when using Huge Pages
In-Reply-To: <20230209192909.GA606606@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox