pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Jim Jones <jim.jones@uni-muenster.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: [PATCH] Add pretty-printed XML output option
Date: Wed, 15 Feb 2023 11:11:59 +0100
Message-ID: <20230215101159.ef5usgukz2qfgp5n@alvherre.pgsql> (raw)
In-Reply-To: <CAHut+PtmMejNUiFQF0qMDMS55nsSN=5Ffw=ywpsEQK2ZxYR7Yw@mail.gmail.com>

On 2023-Feb-13, Peter Smith wrote:

> Something is misbehaving.
> 
> Using the latest HEAD, and before applying the v6 patch, 'make check'
> is working OK.
> 
> But after applying the v6 patch, some XML regression tests are failing
> because the DETAIL part of the message indicating the wrong syntax
> position is not getting displayed. Not only for your new tests -- but
> for other XML tests too.

Note that there's another file, xml_2.out, which does not contain the
additional part of the DETAIL message.  I suspect in Peter's case it's
xml_2.out that was originally being used as a comparison basis (not
xml.out), but that one is not getting patched, and ultimately the diff
is reported for him against xml.out because none of them matches.

An easy way forward might be to manually apply the patch from xml.out to
xml_2.out, and edit it by hand to remove the additional lines.

See commit 085423e3e326 for a bit of background.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/





view thread (70+ messages)  latest in thread

Message-ID: <20230215101159.ef5usgukz2qfgp5n@alvherre.pgsql>
Permalink:  ../20230215101159.ef5usgukz2qfgp5n@alvherre.pgsql/
Also on:    postgresql.org/message-id/20230215101159.ef5usgukz2qfgp5n@alvherre.pgsql

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, smithpb2250@gmail.com, jim.jones@uni-muenster.de, tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com
  Subject: Re: [PATCH] Add pretty-printed XML output option
  In-Reply-To: <20230215101159.ef5usgukz2qfgp5n@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox