public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: Fix misplaced shared_preload_libraries_in_progress check in few extensions
Date: Mon, 20 Mar 2023 18:05:41 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALj2ACVH1BA+GrADan=6oBJR_Dc9-3mBgWsK0CqubT+WNOjQgg@mail.gmail.com>
References: <CALj2ACVH1BA+GrADan=6oBJR_Dc9-3mBgWsK0CqubT+WNOjQgg@mail.gmail.com>

At Sat, 18 Mar 2023 10:26:42 +0530, Bharath Rupireddy <[email protected]> wrote in 
> Hi,
> 
> I'm attaching a patch to do $subject in autoprewarm.c and worker_spi
> extensions. The way it is right now doesn't hurt anyone, but why to
> fail after defining custom GUCs if we aren't loading them via
> shared_preload_libraries.
> 
> Thoughts?

I don't think they're misplaced at least for pg_prewram. pg_prewarm
worker allows to be executed after startup and the variable is still
used by such prewarm worker processes, but the patch make the variable
stop working in that case.

I didn't look at the part for worker_spi.c.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Fix misplaced shared_preload_libraries_in_progress check in few extensions
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox