agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Bossart, Nathan <bossartn@amazon.com>
Cc: Maxim Orlov <orlovmg@gmail.com>
Cc: Amul Sul <sulamul@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: O(n) tasks cause lengthy startups and checkpoints
Date: Sun, 2 Apr 2023 14:17:42 -0700
Message-ID: <20230402211742.GA27239@nathanxps13> (raw)
In-Reply-To: <1056498.1680466985@sss.pgh.pa.us>
References: <CALj2ACUCvhtXO7Ay-7ogxEBAvt74VCajAj=CqWDDTLsZT4+zTA@mail.gmail.com>
<20221201214026.GA1799688@nathanxps13>
<CALj2ACWupmFrhv4ZOdiB8rrt2UuC8bpCO_v=Sbu+fFEoSgYoNw@mail.gmail.com>
<20221202191507.GA2277157@nathanxps13>
<CALj2ACW1F-T866iaqA_9h9fA+Axdyc86CHz7_k55RGH5HH2rtA@mail.gmail.com>
<20230203054808.GA83788@nathanxps13>
<20230217234344.GA3357392@nathanxps13>
<1031491.1680457205@sss.pgh.pa.us>
<20230402193030.GA25018@nathanxps13>
<1056498.1680466985@sss.pgh.pa.us>
On Sun, Apr 02, 2023 at 04:23:05PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> On Sun, Apr 02, 2023 at 01:40:05PM -0400, Tom Lane wrote:
>>> * Why does LookupCustodianFunctions think it needs to search the
>>> constant array?
>
>> The order of the tasks in the array isn't guaranteed to match the order in
>> the CustodianTask enum.
>
> Why not? It's a constant array, we can surely manage to make its
> order match the enum.
Alright. I'll change this.
>>> * The original proposal included moving RemovePgTempFiles into this
>>> mechanism, which I thought was probably the most useful bit of the
>>> whole thing. I'm sad to see that gone, what became of it?
>
>> I postponed that based on advice from upthread [1]. I was hoping to start
>> a dedicated thread for that immediately after the custodian infrastructure
>> was committed. FWIW I agree that it's the most useful task of what's
>> proposed thus far.
>
> Hmm, given Andres' objections there's little point in moving forward
> without that task.
Yeah. I should probably tackle that one first and leave the logical tasks
for later, given there is some prerequisite work required.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
view thread (89+ messages) latest in thread
Message-ID: <20230402211742.GA27239@nathanxps13>
Permalink: ../20230402211742.GA27239@nathanxps13/
Also on: postgresql.org/message-id/20230402211742.GA27239@nathanxps13
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, bharath.rupireddyforpostgres@gmail.com, robertmhaas@gmail.com, andres@anarazel.de, bossartn@amazon.com, orlovmg@gmail.com, sulamul@gmail.com, bruce@momjian.us
Subject: Re: O(n) tasks cause lengthy startups and checkpoints
In-Reply-To: <20230402211742.GA27239@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox