From: Noah Misch <noah@leadboat.com>
To: Andres Freund <andres@anarazel.de>
Cc: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: fabriziomello@gmail.com, tushar <tushar.ahuja@enterprisedb.com>
Cc: Rahila Syed <rahila.syed@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Minimal logical decoding on standbys
Date: Tue, 11 Apr 2023 22:07:44 -0700
Message-ID: <20230412050744.GA1217255@rfd.leadboat.com> (raw)
In-Reply-To: <20230411201057.qsjw7pjgtpvxcvn2@awork3.anarazel.de>
References: <71c3d91a-6b3b-5c0a-ffb9-630f17fe693e@gmail.com>
<20230407075009.igg7be27ha2htkbt@awork3.anarazel.de>
<1e923731-ed09-3621-c8b9-61f938b4c355@gmail.com>
<20230407154757.ywqnldz4nsycap3g@awork3.anarazel.de>
<20230407181226.6oyt4jcazy6eh7rx@awork3.anarazel.de>
<20230411053657.GA1177147@rfd.leadboat.com>
<7eb26a22-a6b2-f938-6d3c-6adcf4785004@gmail.com>
<e217cdaf-53a1-6d41-59e2-4f4a8bbe9f23@gmail.com>
<002cc876-0838-2821-e9d8-bb3791386814@gmail.com>
<20230411201057.qsjw7pjgtpvxcvn2@awork3.anarazel.de>
On Tue, Apr 11, 2023 at 01:10:57PM -0700, Andres Freund wrote:
> On 2023-04-11 11:04:50 +0200, Drouvot, Bertrand wrote:
> > On 4/11/23 10:55 AM, Drouvot, Bertrand wrote:
> > > I think we might want to add:
> > >
> > > $node_primary->wait_for_replay_catchup($node_standby);
> > >
> > > before calling the slot creation.
> Pushed. Seems like a clear race in the test, so I didn't think it was worth
> waiting for testing it on hoverfly.
We'll see what happens in the next run.
> I think we should lower the log level, but perhaps wait for a few more cycles
> in case there are random failures?
Fine with me.
> I wonder if we should make the connections in poll_query_until to reduce
> verbosity - it's pretty annoying how much that can bloat the log. Perhaps also
> introduce some backoff? It's really annoying to have to trawl through all
> those logs when there's a problem.
Agreed. My ranked wish list for poll_query_until is:
1. Exponential backoff
2. Closed-loop time control via Time::HiRes or similar, instead of assuming
that ten loops complete in ~1s. I've seen the loop take 3x as long as the
intended timeout.
3. Connect less often than today's once per probe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, andres@anarazel.de, bertranddrouvot.pg@gmail.com, amit.kapila16@gmail.com, alvherre@alvh.no-ip.org, pgsql@j-davis.com, robertmhaas@gmail.com, thomas.munro@gmail.com, ibrar.ahmad@gmail.com, amitdkhan.pg@gmail.com, tushar.ahuja@enterprisedb.com, rahila.syed@2ndquadrant.com
Subject: Re: Minimal logical decoding on standbys
In-Reply-To: <20230412050744.GA1217255@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox