From: Sandro Santilli <strk@kbt.io>
To: Przemysław Sztoch <przemyslaw@sztoch.pl>
Cc: Yurii Rashkovskii <yrashk@gmail.com>
Cc: Eric Ridge <eebbrr@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Regina Obe <lr@pcorp.us>
Cc: Regina Obe <r@pcorp.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
Date: Wed, 31 May 2023 19:13:50 +0200
Message-ID: <20230531171350.txpt7udupfwwg44s@c19> (raw)
In-Reply-To: <29e81ac7-9fad-573a-6319-9a8265320c2d@sztoch.pl>
References: <29e81ac7-9fad-573a-6319-9a8265320c2d@sztoch.pl>
On Thu, May 18, 2023 at 11:14:52PM +0200, Przemysław Sztoch wrote:
> For me, it would be a big help if you could specify a simple from/to range
> as the source version:
> myext--1.0.0-1.9.9--2.0.0.sql
> myext--2.0.0-2.9.9--3.0.0.sql
> myext--3.0.0-3.2.3--3.2.4.sql
>
> The idea of % wildcard in my opinion is fully contained in the from/to
> range.
Yes, it will be once partial matching is implemented (in its current
state the patch only allows the wildcard to cover the whole version,
not just a portion, but the idea was to move to partial matches too).
> The name "ANY" should also be allowed as the source version.
It is. The only character with a special meaning, in my patch, would
be the "%" character, and would ONLY be special if the extension has
set the wildcard_upgrades directive to "true" in the .control file.
> Some extensions are a collection of CREATE OR REPLACE FUNCTION. All upgrades
> are one and the same SQL file.
Yes, this is the case for PostGIS, and that's why we're looking
forward to addint support for this wildcard.
--strk;
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: strk@kbt.io, przemyslaw@sztoch.pl, yrashk@gmail.com, eebbrr@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, lr@pcorp.us, r@pcorp.us, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
In-Reply-To: <20230531171350.txpt7udupfwwg44s@c19>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox