public inbox for [email protected]
help / color / mirror / Atom feedFrom: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: Consistent coding for the naming of LR workers
Date: Fri, 16 Jun 2023 10:43:27 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHut+Pt1xwATviPGjjtJy5L631SGf3qjV9XUCmxLu16cHamfgg@mail.gmail.com>
References: <CAHut+Pt1xwATviPGjjtJy5L631SGf3qjV9XUCmxLu16cHamfgg@mail.gmail.com>
At Thu, 15 Jun 2023 12:42:33 +1000, Peter Smith <[email protected]> wrote in
> It is better to have a *single* point where these worker names are
> defined, so then all output uses identical LR worker nomenclature.
>
> PSA a small patch to modify the code accordingly. This is not intended
> to be a functional change - just a code cleanup.
>
> Thoughts?
I generally like this direction when it actually decreases the number
of translatable messages without making grepping on the tree
excessively difficult. However, in this case, the patch doesn't seems
to reduce the translatable messages; instead, it makes grepping
difficult.
Addition to that, I'm inclined to concur with Alvaro regarding the
gramattical aspect.
Consequently, I'd prefer to leave these alone.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Consistent coding for the naming of LR workers
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox