public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: Dagfinn Ilmari Mannsåker <[email protected]>
Cc: [email protected]
Subject: Re: Obsolete reference to pg_relation in comment
Date: Wed, 26 Jul 2023 12:11:53 -0700
Message-ID: <20230726191153.GA3315838@nathanxps13> (raw)
In-Reply-To: <20230726185306.GB3310393@nathanxps13>
References: <[email protected]>
	<20230726185306.GB3310393@nathanxps13>

On Wed, Jul 26, 2023 at 11:53:06AM -0700, Nathan Bossart wrote:
> On Wed, Jul 26, 2023 at 06:48:51PM +0100, Dagfinn Ilmari Mannsåker wrote:
>> Triggered by a discussion on IRC, I noticed that there's a stray
>> reference to pg_relation in a comment that was added long after it was
>> renamed to pg_class.  Here's a patch to bring that up to speed.
> 
>> pg_relation was renamed to pg_class in 1991, but this comment (added
>> in 2004) missed the memo
> 
> Huh, interesting!  I dug around the Berkeley archives [0] and found
> comments indicating that pg_relation was renamed to pg_class in Februrary
> 1990.  However, it looks like the file was named pg_relation.h until
> Postgres95 v0.01, which has the following comment in pg_class.h:
> 
> 	 *    ``pg_relation'' is being replaced by ``pg_class''.  currently
> 	 *    we are only changing the name in the catalogs but someday the
> 	 *    code will be changed too. -cim 2/26/90
> 	 *    [it finally happens.  -ay 11/5/94]

This comment actually lived in Postgres until 9cf80f2 (June 2000), too.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Obsolete reference to pg_relation in comment
  In-Reply-To: <20230726191153.GA3315838@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox