From: Noah Misch <noah@leadboat.com>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Alexander Lakhin <exclusion@gmail.com>
Subject: Re: Getting rid of OverrideSearhPath in namespace.c
Date: Mon, 31 Jul 2023 20:06:28 -0400
Message-ID: <20230801000628.GA10592@gust.leadboat.com> (raw)
In-Reply-To: <CAJ7c6TN+oLH-qEyMmDruA_hQm3EV6qUj4P_JTbVfq0YL=WsVdg@mail.gmail.com>
References: <8ffb4650-52c4-6a81-38fc-8f99be981130@gmail.com>
<CAJ7c6TN+oLH-qEyMmDruA_hQm3EV6qUj4P_JTbVfq0YL=WsVdg@mail.gmail.com>
On Mon, Jul 17, 2023 at 05:11:46PM +0300, Aleksander Alekseev wrote:
> > As a follow-up for the CVE-2023-2454 fix, I think that it makes sense to
> > completely remove unsafe functions
> > PushOverrideSearchPath()/PopOverrideSearchPath(), which are not used in the
> > core now.
> > Please look at the patch attached.
> >
> > [...]
> >
> > What do you think?
>
> +1 to remove dead code.
>
> The proposed patch however removes get_collation_oid(), apparently by
> mistake. Other than that the patch looks fine and passes `make
> installcheck-world`.
>
> I added an entry to the nearest CF [1].
>
> > Beside that, maybe it's worth to rename three functions in "Override" in
> > their names: GetOverrideSearchPath(), CopyOverrideSearchPath(),
> > OverrideSearchPathMatchesCurrent(), and then maybe struct OverrideSearchPath.
> > Noah Misch proposed name GetSearchPathMatcher() for the former.
>
> +1 as well. I added the corresponding 0002 patch.
Pushed both. Thanks.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, aleksander@timescale.com, exclusion@gmail.com
Subject: Re: Getting rid of OverrideSearhPath in namespace.c
In-Reply-To: <20230801000628.GA10592@gust.leadboat.com>
References: <8ffb4650-52c4-6a81-38fc-8f99be981130@gmail.com> <CAJ7c6TN+oLH-qEyMmDruA_hQm3EV6qUj4P_JTbVfq0YL=WsVdg@mail.gmail.com> <20230801000628.GA10592@gust.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox