pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: add timing information to pg_upgrade
Date: Wed, 23 Aug 2023 09:35:20 -0700
Message-ID: <20230823163520.GA1064471@nathanxps13> (raw )
In-Reply-To: <20230822140623.GA600331@nathanxps13 >
References: <20230728173814.GA3765390@nathanxps13 >
<20230728184735.GC3661419@nathanxps13 >
<CALj2ACVVvk1cYLtWVxHv=Z1Ubq=UES9fhKbUU4c9k4W+fEDnbw@mail.gmail.com >
<20230729211418.GA189222@nathanxps13 >
<CALj2ACUEkFmk8x8XTuN=ZgEMtQ6zuZP2jDy4Ri-woaL0i1ABfg@mail.gmail.com >
<20230731183702.GA537853@nathanxps13 >
<d92952c7-e97d-933e-2558-ebe3708336e8@eisentraut.org >
<20230801154554.GA723589@nathanxps13 >
<632b1c6b-fc51-816b-4848-4063551777b0@eisentraut.org >
<20230822140623.GA600331@nathanxps13 >
On Tue, Aug 22, 2023 at 07:06:23AM -0700, Nathan Bossart wrote:
> On Tue, Aug 22, 2023 at 11:49:33AM +0200, Peter Eisentraut wrote:
>> Let's change MESSAGE_WIDTH to 62 in v16, and then pursue the larger
>> restructuring leisurely.
>
> Sounds good. I plan to commit this within the next couple of days.
Here's the patch. I'm going to run a couple of tests before committing,
but I don't think anything else is required.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Attachments:
0001-bump-MESSAGE_WIDTH-to-62.patch (text/x-diff, 669B) download
From e2f65937666ec31004ec7668c475dd33c4ab0a91 Mon Sep 17 00:00:00 2001
From: Nathan Bossart <nathan@postgresql.org>
Date: Wed, 23 Aug 2023 09:31:11 -0700
Subject: [PATCH 1/1] bump MESSAGE_WIDTH to 62
---
src/bin/pg_upgrade/pg_upgrade.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/pg_upgrade/pg_upgrade.h b/src/bin/pg_upgrade/pg_upgrade.h
index 3eea0139c7..7afa96716e 100644
--- a/src/bin/pg_upgrade/pg_upgrade.h
+++ b/src/bin/pg_upgrade/pg_upgrade.h
@@ -22,7 +22,7 @@
#define MAX_STRING 1024
#define QUERY_ALLOC 8192
-#define MESSAGE_WIDTH 60
+#define MESSAGE_WIDTH 62
#define GET_MAJOR_VERSION(v) ((v) / 100)
--
2.25.1
view thread (29+ messages) latest in thread
Message-ID: <20230823163520.GA1064471@nathanxps13>
Permalink: ../20230823163520.GA1064471@nathanxps13/
Also on: postgresql.org/message-id/20230823163520.GA1064471@nathanxps13
copy link · copy postgr.es · copy git am
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, peter@eisentraut.org, bharath.rupireddyforpostgres@gmail.com
Subject: Re: add timing information to pg_upgrade
In-Reply-To: <20230823163520.GA1064471@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox