public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alvaro Herrera <[email protected]>
To: Amit Langote <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: jian he <[email protected]>
Cc: Erik Rijkers <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: remaining sql/json patches
Date: Thu, 28 Sep 2023 13:04:54 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+HiwqFJQdBQzTbSt6=S_3mmYf_pb2YoRNrhL1R0zzFz5Yja=w@mail.gmail.com>
On 2023-Sep-27, Amit Langote wrote:
> Maybe the following is better:
>
> + /*
> + * For expression nodes that support soft errors. Should be set to NULL
> + * before calling ExecInitExprRec() if the caller wants errors thrown.
> + */
>
> ...as in the attached.
That's good.
> Alvaro, do you think your concern regarding escontext not being in the
> right spot in the ExprState struct is addressed? It doesn't seem very
> critical to me to place it in the struct's 1st cacheline, because
> escontext is not accessed in performance critical paths such as during
> expression evaluation, especially with the latest version. (It would
> get accessed during evaluation with previous versions.)
>
> If so, I'd like to move ahead with committing it.
Yeah, looks OK to me in v21.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: remaining sql/json patches
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox