public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v24 04/10] default to --with-lz4 2+ messages / 2 participants [nested] [flat]
* [PATCH v24 04/10] default to --with-lz4 @ 2021-02-14 04:11 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Justin Pryzby @ 2021-02-14 04:11 UTC (permalink / raw) this is meant to excercize the new feature in the CIs, and not meant to be merged --- configure | 6 ++++-- configure.ac | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 0895b2f326..79e9d226ff 100755 --- a/configure +++ b/configure @@ -1571,7 +1571,7 @@ Optional Packages: --with-system-tzdata=DIR use system time zone data in DIR --without-zlib do not use Zlib - --with-lz4 build with LZ4 support + --without-lz4 build without LZ4 support --with-gnu-ld assume the C compiler uses GNU ld [default=no] --with-ssl=LIB use LIB for SSL/TLS support (openssl) --with-openssl obsolete spelling of --with-ssl=openssl @@ -8592,7 +8592,9 @@ $as_echo "#define USE_LZ4 1" >>confdefs.h esac else - with_lz4=no + with_lz4=yes + +$as_echo "#define USE_LZ4 1" >>confdefs.h fi diff --git a/configure.ac b/configure.ac index 63940b78a0..62180c5424 100644 --- a/configure.ac +++ b/configure.ac @@ -990,8 +990,8 @@ AC_SUBST(with_zlib) # LZ4 # AC_MSG_CHECKING([whether to build with LZ4 support]) -PGAC_ARG_BOOL(with, lz4, no, [build with LZ4 support], - [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build with LZ4 support. (--with-lz4)])]) +PGAC_ARG_BOOL(with, lz4, yes, [build without LZ4 support], + [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build without LZ4 support. (--without-lz4)])]) AC_SUBST(with_lz4) # -- 2.17.0 --m51xatjYGsM+13rf Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v24-0005-fixups.patch.patch" ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: remaining sql/json patches @ 2023-09-28 11:04 Alvaro Herrera <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Alvaro Herrera @ 2023-09-28 11:04 UTC (permalink / raw) To: Amit Langote <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; jian he <[email protected]>; Erik Rijkers <[email protected]>; pgsql-hackers On 2023-Sep-27, Amit Langote wrote: > Maybe the following is better: > > + /* > + * For expression nodes that support soft errors. Should be set to NULL > + * before calling ExecInitExprRec() if the caller wants errors thrown. > + */ > > ...as in the attached. That's good. > Alvaro, do you think your concern regarding escontext not being in the > right spot in the ExprState struct is addressed? It doesn't seem very > critical to me to place it in the struct's 1st cacheline, because > escontext is not accessed in performance critical paths such as during > expression evaluation, especially with the latest version. (It would > get accessed during evaluation with previous versions.) > > If so, I'd like to move ahead with committing it. Yeah, looks OK to me in v21. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-09-28 11:04 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-02-14 04:11 [PATCH v24 04/10] default to --with-lz4 Justin Pryzby <[email protected]> 2023-09-28 11:04 Re: remaining sql/json patches Alvaro Herrera <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox