pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <fujii@postgresql.org>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: stopgap fix for signal handling during restore_command
Date: Wed, 11 Oct 2023 14:00:00 -0500
Message-ID: <20231011190000.GA894647@nathanxps13> (raw)
In-Reply-To: <ZSYeRi9isT7rzZ_a@paquier.xyz>
References: <20230226180029.djk7cth4o3o5doom@awork3.anarazel.de>
	<20230226193900.GA1248604@nathanxps13>
	<20230226201227.cner3cdicropu4q5@awork3.anarazel.de>
	<20230301043603.GD1453450@nathanxps13>
	<20230301224751.GA1823946@nathanxps13>
	<20231010234028.iba6wotmp22poxoh@awork3.anarazel.de>
	<20231011025418.GA845134@nathanxps13>
	<20231011032934.GA847236@nathanxps13>
	<20231011033929.j7doct7wzmyw6xiu@awork3.anarazel.de>
	<ZSYeRi9isT7rzZ_a@paquier.xyz>

On Wed, Oct 11, 2023 at 01:02:14PM +0900, Michael Paquier wrote:
> On Tue, Oct 10, 2023 at 08:39:29PM -0700, Andres Freund wrote:
>> We shouldn't call proc_exit() in a signal handler. We perhaps have a few
>> remaining calls left, but we should (and I think in some cases are) working on
>> removing those.

Got it.

> Hmm.  I don't recall anything remaining, even after a quick check.
> FWIW, I was under the impression that Thomas' work done in
> 0da096d78e1e4 has cleaned up the last bits of that.

StartupProcShutdownHandler() remains, at least.  Of the other items in
Tom's list from 2020 [0], bgworker_die() and FloatExceptionHandler() are
also still unsafe.  RecoveryConflictInterrupt() should be fixed by 0da096d,
and StandbyDeadLockHandler() and StandbyTimeoutHandler() should be fixed by
8900b5a and 8f1537d, respectively.

[0] https://postgr.es/m/148145.1599703626%40sss.pgh.pa.us

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (29+ messages)  latest in thread

Message-ID: <20231011190000.GA894647@nathanxps13>
Permalink:  ../20231011190000.GA894647@nathanxps13/
Also on:    postgresql.org/message-id/20231011190000.GA894647@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, michael@paquier.xyz, andres@anarazel.de, thomas.munro@gmail.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, fujii@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: stopgap fix for signal handling during restore_command
  In-Reply-To: <20231011190000.GA894647@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox