pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: [HACKERS] Bug in ExecModifyTable function and trigger issues for foreign tables
Date: Mon, 27 Nov 2017 11:35:36 -0500
Message-ID: <20240.1511800536@sss.pgh.pa.us> (raw)
In-Reply-To: <18636.1511797772@sss.pgh.pa.us>
References: <20170514150525.0346ba72@postgrespro.ru>
	<20170515165455.545dd3d6@wp.localdomain>
	<CAFjFpRcQudmKYU4PJRN1-wp5K4aksupSoVpcRVAzES_49T=Vng@mail.gmail.com>
	<20170516150516.1b616230@wp.localdomain>
	<CAFjFpReeA3G3-U-FsR79zx_xFBVZc73hhWcH4OVWMb+ZFViRQg@mail.gmail.com>
	<dbf4b9ff-b0be-2396-7c79-d5763ae8a034@lab.ntt.co.jp>
	<f62d1797-2817-0f2e-eb7b-38da40504c8d@lab.ntt.co.jp>
	<a31f779e-9cb8-1ea5-71a6-bca6adbfa6a4@lab.ntt.co.jp>
	<20170615180548.5e142ddc@wp.localdomain>
	<0bc9c28b-96ca-c875-871e-16af6f53ecd9@lab.ntt.co.jp>
	<CAFjFpReUW9JhuyEq5mhi2Hrt3KpjHHP8LnWBZQhrHek3c0KGVQ@mail.gmail.com>
	<428f1672-df54-de01-91da-b57365193bf4@lab.ntt.co.jp>
	<d0a12e42-e20a-b561-76ed-7fa48d4b520a@lab.ntt.co.jp>
	<6c651916-8fde-f9c9-b199-080df1bf2867@lab.ntt.co.jp>
	<280720c5-7aad-1136-6be3-654208c8f714@lab.ntt.co.jp>
	<8065.1500475011@sss.pgh.pa.us>
	<9cd25d80-08fc-568c-3181-dbe98723d0db@lab.ntt.co.jp>
	<3e9ff40d-d00f-3363-dcee-97ce023c7884@lab.ntt.co.jp>
	<f8aa99d0-627d-32dc-fbc7-4e5943f9d652@lab.nt! t.co.jp>
	<14028.1511736992@sss.pgh.pa.us>
	<CAEZATCUGUnUoDJC=bf-L_vdMjMKDxUXN+XudkuN5wf4FDKNT=A@mail.gmail.com>
	<18636.1511797772@sss.pgh.pa.us>

I wrote:
> Dean Rasheed <dean.a.rasheed@gmail.com> writes:
>> A separate point -- it might be marginally more efficient to have the
>> work of rewriteTargetListUD() done after expand_targetlist() to avoid
>> the possible renumbering of the resjunk entries.

> Hm.  It wouldn't save a lot, but yeah, doing it in this order seems
> a bit silly when you put it like that.

On looking closer, the reason it's like that in Fujita-san's patch
is to minimize the API churn seen by FDW AddForeignUpdateTargets
functions, specifically whether they see a tlist that's before or
after what expand_targetlist() does.  I'm doubtful that the
potential savings is worth taking risks there.  In particular,
it seems like a good thing that expand_targetlist() verifies the
correct tlist ordering *after* the FDW function has acted.
So now my inclination is to leave this alone.

			regards, tom lane




view thread (43+ messages)  latest in thread

Message-ID: <20240.1511800536@sss.pgh.pa.us>
Permalink:  ../20240.1511800536@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/20240.1511800536@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dean.a.rasheed@gmail.com, fujita.etsuro@lab.ntt.co.jp, ashutosh.bapat@enterprisedb.com, i.kurbangaliev@postgrespro.ru, dilipbalaut@gmail.com, robertmhaas@gmail.com
  Subject: Re: [HACKERS] Bug in ExecModifyTable function and trigger issues for foreign tables
  In-Reply-To: <20240.1511800536@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox