From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Cc: Amit Langote <amitlangote09@gmail.com>
Subject: Re: Running the fdw test from the terminal crashes into the core-dump
Date: Fri, 23 Feb 2024 23:03:01 +0100
Message-ID: <202402232203.u6k7pvhhbqxy@alvherre.pgsql> (raw)
In-Reply-To: <708233.1708645700@sss.pgh.pa.us>
On 2024-Feb-22, Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > I propose the attached. (Extra context so that the full paragraph can
> > be read from the comfort of your email program.)
>
> This reads awkwardly to me. I think it'd be better to construct it
> so that DO NOTHING's requirement is stated exactly parallel to the other
> three clause types, more or less as attached.
Sure, that works.
> BTW, if you read it without paying attention to markup, you'll notice
> that we are saying things like
>
> If you specify an insert action, you must have the INSERT
> privilege on the target_table_name.
>
> which is fairly nonsensical: we don't define privileges on the name
> of something.
Hmm, you're right, this is not strictly correct.
> While I've not done anything about that here, I wonder if we shouldn't
> just write "privilege on the target table" without any special markup.
That would work for me.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us, a.rybakina@postgrespro.ru, amitlangote09@gmail.com
Subject: Re: Running the fdw test from the terminal crashes into the core-dump
In-Reply-To: <202402232203.u6k7pvhhbqxy@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox