From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Nathan Bossart <nathan@postgresql.org>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Allow using syncfs() in frontend utilities.
Date: Tue, 26 Mar 2024 09:52:10 -0500
Message-ID: <20240326145210.GA3181099@nathanxps13> (raw)
In-Reply-To: <CA+TgmobUiqKr+ZMCLc5Qap-sXBnjfGUU+ZBmzYEjUuWyjsGr1g@mail.gmail.com>
References: <E1qe1wG-002jjs-Fr@gemulon.postgresql.org>
<CA+TgmobUiqKr+ZMCLc5Qap-sXBnjfGUU+ZBmzYEjUuWyjsGr1g@mail.gmail.com>
On Fri, Mar 22, 2024 at 12:52:15PM -0400, Robert Haas wrote:
> I'd like to complain about this commit's addition of a new appendix. I
> do understand the temptation to document caveats like this centrally
> instead of in multiple places, but as I've been complaining about over
> in the "documentation structure" thread, our top-level documentation
> index is too big, and I feel strongly that we need to de-clutter it
> rather than cluttering it further. This added a new chapter which is
> just 5 sentences long. I understand that this was done because the
> same issue applies to a bunch of different utilities and we didn't
> want to duplicate this text in all of those places, but I feel like
> this approach just doesn't scale. If we did this in every place where
> we have this much text that we want to avoid duplicating, we'd soon
> have hundreds of appendixes.
Sorry I missed this. I explored a couple of options last year but the
discussion trailed off [0].
> What I would suggest we do instead is pick one of the places where
> this comes up and document it there, perhaps the
> recovery_init_sync_method GUC. And then make the documentation for the
> other say something like, you know those issues we documented for
> recovery_init_sync_method? Well they also apply to this.
WFM. I'll put together a patch.
[0] https://postgr.es/m/20231009204823.GA659480%40nathanxps13
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, robertmhaas@gmail.com, nathan@postgresql.org
Subject: Re: pgsql: Allow using syncfs() in frontend utilities.
In-Reply-To: <20240326145210.GA3181099@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox