public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ole Peder Brandtzæg <[email protected]>
To: [email protected]
Subject: Re: NumericShort vs NumericLong format
Date: Tue, 9 Apr 2024 13:41:15 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAF-KA8_Uf_LZ1krmNdiSJtCoMqSzjdjQRFc=ZK=fQoOFKShF-Q@mail.gmail.com>
	<CAKFQuwbUxr-u2BT2PQ4Q_n_o0DieipneHQE+VEPML96bnR3HDQ@mail.gmail.com>
	<[email protected]>

On Tue, Mar 07, 2023 at 12:15:27AM -0500, Tom Lane wrote:
> "David G. Johnston" <[email protected]> writes:
> > As an aside, for anyone more fluent than I who reads this, is the use of
> > the word "dynamic scale" in this code comment supposed to be "display
> > scale"?
> > https://github.com/postgres/postgres/blob/cf96907aadca454c4094819c2ecddee07eafe203/src/backend/utils...
> 
> Yeah, I think you're right.

Familiarizing myself with numeric.c today, I too was confused by this.
AFAICT, it's meant to say display scale as used elsewhere in the file;
for instance, the comment for NumericShort's n_header reads "Sign +
display scale + weight". Would it be appropriate if I submitted a patch
for this? It's admittedly trivial, but I figured I should say hi before
submitting one.

All the best,
Ole

-- 
Ole Peder Brandtzæg | En KLST/ITK-hybrid
Please don't look at me with those eyes
Please don't hint that you're capable of lies

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: NumericShort vs NumericLong format
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox