From: Noah Misch <noah@leadboat.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Weird test mixup
Date: Tue, 7 May 2024 15:00:23 -0700
Message-ID: <20240507220023.47.nmisch@google.com> (raw)
In-Reply-To: <20240507185310.d3@rfd.leadboat.com>
References: <ZfP7IDs9TvrKe49x@paquier.xyz>
<e1a7ab78-1fa9-419c-b0d1-36d971bdf946@iki.fi>
<ZfTcZW1-Kh3fFLnZ@paquier.xyz>
<20240501231214.40@rfd.leadboat.com>
<ZjNAUN5Hek-MyVWv@paquier.xyz>
<20240502193555.a1.nmisch@google.com>
<ZjgsaYs44ici4QMW@paquier.xyz>
<20240506212324.2e.nmisch@google.com>
<ZjmBPeB6LQeHVHZ7@paquier.xyz>
<20240507185310.d3@rfd.leadboat.com>
On Tue, May 07, 2024 at 11:53:10AM -0700, Noah Misch wrote:
> On Tue, May 07, 2024 at 10:17:49AM +0900, Michael Paquier wrote:
> > Overall, this switches from one detach behavior to a different one,
>
> Can you say more about that? The only behavior change known to me is that a
> given injection point workload uses more of INJ_MAX_CONDITION. If there's
> another behavior change, it was likely unintended.
I see patch inplace030-inj-exit-race-v1.patch does not fix the race seen with
repro-inj-exit-race-v1.patch. I withdraw inplace030-inj-exit-race-v1.patch,
and I withdraw the above question.
> To reproduce, apply [repro-inj-exit-race-v1.patch] to add
> sleeps, and run:
>
> make -C src/test/modules/gin installcheck USE_MODULE_DB=1 & sleep 2; make -C contrib/intarray installcheck USE_MODULE_DB=1
>
> Separately, I see injection_points_attach() populates InjectionPointCondition
> after InjectionPointAttach(). Shouldn't InjectionPointAttach() come last, to
> avoid the same sort of race? I've not tried to reproduce that one.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, michael@paquier.xyz, hlinnaka@iki.fi, tgl@sss.pgh.pa.us
Subject: Re: Weird test mixup
In-Reply-To: <20240507220023.47.nmisch@google.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox