public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alvaro Herrera <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Subject: Re: Missing reflection in nls.mk from recent basebackup changes
Date: Mon, 12 Aug 2024 18:54:37 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2024-Aug-06, Michael Paquier wrote:

> On Tue, Aug 06, 2024 at 10:21:23AM +0900, Kyotaro Horiguchi wrote:
> > After a recent commit f80b09bac8, make update-po fails with "missing
> > required files". The commit moved some files to fe_utils but this
> > change was not reflected in pg_basebackup's nls.mk. The attached patch
> > fixes this issue.
> 
> You are right.  Still, it is not something that committers are
> required to update when introducing new files, isn't it?  I don't see
> why we should be aggressive here for HEAD.

Well, make targets should always work.

> ad8877cb5137 has done a large batch of these for the v17 cycle.

IIUC that's slightly different -- it concerns files that contain
*additional* files that msgmerge need to scan in order to extract
translatable strings.  This patch is about fixing bogus file locations
in the makefiles.  So without this patch, update-po fails; without the
commit you mention, update-po continues to run, the only problem is it
misses a few files.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"El sentido de las cosas no viene de las cosas, sino de
las inteligencias que las aplican a sus problemas diarios
en busca del progreso." (Ernesto Hernández-Novich)

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Missing reflection in nls.mk from recent basebackup changes
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox