public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Subject: Re: Missing reflection in nls.mk from recent basebackup changes
Date: Tue, 6 Aug 2024 10:39:10 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Tue, Aug 06, 2024 at 10:21:23AM +0900, Kyotaro Horiguchi wrote:
> After a recent commit f80b09bac8, make update-po fails with "missing
> required files". The commit moved some files to fe_utils but this
> change was not reflected in pg_basebackup's nls.mk. The attached patch
> fixes this issue.

You are right.  Still, it is not something that committers are
required to update when introducing new files, isn't it?  I don't see
why we should be aggressive here for HEAD.

ad8877cb5137 has done a large batch of these for the v17 cycle.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Missing reflection in nls.mk from recent basebackup changes
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox