public inbox for [email protected]  

help / color / mirror / Atom feed

From: Yugo Nagata <[email protected]>
To: px shi <[email protected]>
Cc: [email protected]
Subject: Re: Remove unlogged materialized view persistence handling
Date: Fri, 11 Oct 2024 12:27:13 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAccyYKRZ=OvAvgowiSH+OELbStLP=p2Ht=R3CgT=OaNSH5DAA@mail.gmail.com>
References: <CAAccyYKRZ=OvAvgowiSH+OELbStLP=p2Ht=R3CgT=OaNSH5DAA@mail.gmail.com>

On Fri, 11 Oct 2024 10:35:17 +0800
px shi <[email protected]> wrote:

> Hi，
> 
> Since materialized views do not support the unlogged type, I think that we
> should remove the logic and handling related to unlogged. Therefore, I have
> submitted a patch.

+1

Materialized view is introduced by 3bf3ab8c563 and at that UNLOGGED was
allowed, and it is disallowed by another commit 3223b25ff73. However,
it seems that the tab-complement is missed to fixed.

The Assert for RELKIND_MATVIEW in heapam_hander.c was introduced in d25f519107b
after that, but I think it can be also removed.

Regards,
Yugo Nagata

-- 
Yugo Nagata <[email protected]>

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Remove unlogged materialized view persistence handling
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox