From: Yugo NAGATA <nagata@sraoss.co.jp>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: tgl@sss.pgh.pa.us
Cc: bruce@momjian.us
Cc: daniel@yesql.se
Cc: pgsql-hackers@postgresql.org
Subject: Re: Doc: typo in config.sgml
Date: Fri, 11 Oct 2024 12:36:53 +0900
Message-ID: <20241011123653.09a67d3ad7b60a59e4558403@sraoss.co.jp> (raw)
In-Reply-To: <20241011.121650.2077607600187658573.ishii@postgresql.org>
References: <2565921.1728531809@sss.pgh.pa.us>
<20241010.160041.949661508167788393.ishii@postgresql.org>
<20241011114122.c90f8a871462da36f2e2afeb@sraoss.co.jp>
<20241011.121650.2077607600187658573.ishii@postgresql.org>
On Fri, 11 Oct 2024 12:16:50 +0900 (JST)
Tatsuo Ishii <ishii@postgresql.org> wrote:
> > We can check non-ASCII letters SGML/XML files by preparing "allowlist"
> > that contains lines which are allowed to have non-ascii characters,
> > although this list will need to be maintained when lines in it are modified.
> > I've attached a patch to add a simple Perl script to do this.
>
> I doubt it really works. For example, nbsp can be used formatting
> (that's the purpose of the character in the first place). Whenever a
> developer decides to or not to use nbsp, "allowlist" needs to be
> maintained. It's too annoying.
I suppose non-ascii characters including nbsp are basically disallowed,
so the allowlist will not increase unless there is some special reason.
However, it is true that there might be a cost for maintaining the list
more or less, so if people don't think it is worth adding this check,
I will withdraw this proposal.l.
> I think it's better to add the non-ASCII character checking to the
> comitting check list and let committers check non-ASCII character in
> the patch. Non-ASCII characters rarely used and it would not become a
> burden.
> https://wiki.postgresql.org/wiki/Committing_checklist
>
> Maybe we can add to the wiki page something like this?
>
> git diff origin/master | grep -P '[^\x00-\x7f]'
>
> > During testing this script, I found "stylesheet-man.xsl" also has non-ascii
> > characters. I don't know these characters are really necessary though, since
> > I don't understand this file well.
>
> They are U+201C (double turned comma quotation mark) and U+201D
> (double comma quotation mark).
>
> <l:template name="sect3" text="Section %n, “%t”, in the documentation"/>
>
> I would like to know why they are necessary too.
+1
Regards,
Yugo Nagata
--
Yugo NAGATA <nagata@sraoss.co.jp>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nagata@sraoss.co.jp, ishii@postgresql.org, tgl@sss.pgh.pa.us, bruce@momjian.us, daniel@yesql.se
Subject: Re: Doc: typo in config.sgml
In-Reply-To: <20241011123653.09a67d3ad7b60a59e4558403@sraoss.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox