public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alvaro Herrera <[email protected]>
To: Kirill Reshke <[email protected]>
Cc: jian he <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: attndims, typndims still not enforced, but make the value within a sane threshold
Date: Thu, 5 Dec 2024 15:43:08 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALdSSPiNPB78tvH2Z2vFT3STwyV5j99dNLataW5c28AOMcMh_Q@mail.gmail.com>

On 2024-Dec-05, Kirill Reshke wrote:

> On Fri, 20 Sept 2024 at 07:11, jian he <[email protected]> wrote:
> > attached patch removes attndims and typndims entirely.
> 
> LGTM?
> I see no open items in this thread. Are there any issues about v1?

Should we leave TupleDescInitEntry()'s API alone, to avoid breaking the
compilation of every extension in the world?  Maybe we could rename the
function (say to TupleDescInitializeEntry()) and use a define?

#define TupleDescInitEntry(a,b,c,d,e,f) TupleDescInitializeEntry(a,b,c,d,e)

Then the amount of churn is reduced, no extensions are broken, and we
can remove the define in a few years.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Debido a que la velocidad de la luz es mucho mayor que la del sonido,
 algunas personas nos parecen brillantes un minuto antes
 de escuchar las pelotudeces que dicen." (Roberto Fontanarrosa)

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: attndims, typndims still not enforced, but make the value within a sane threshold
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox