pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Zeugswetter Andreas ADI SD <ZeugswetterA@spardat.at>
Cc: Koichi Suzuki <suzuki.koichi@oss.ntt.co.jp>
Cc: Hannu Krosing <hannu@skype.net>
Cc: Joshua D. Drake <jd@commandprompt.com>
Cc: josh@agliodbs.com
Cc: pgsql-hackers@postgresql.org
Cc: pgsql-patches@postgresql.org
Subject: Re: [HACKERS] Full page writes improvement, code update
Date: Fri, 13 Apr 2007 12:50:33 -0400
Message-ID: <20249.1176483033@sss.pgh.pa.us> (raw)
In-Reply-To: <1176480368.3635.199.camel@silverbirch.site>
References: <460886E8.6040907@oss.ntt.co.jp>
	<4609CAC3.7060008@oss.ntt.co.jp>
	<1175072848.4386.323.camel@silverbirch.site>
	<200703291145.28574.josh@agliodbs.com>
	<1175200117.4386.616.camel@silverbirch.site>
	<460C611E.6090800@oss.ntt.co.jp>
	<27693.1176226131@sss.pgh.pa.us>
	<461C3557.6040201@oss.ntt.co.jp>
	<461C3732.20006@commandprompt.com>
	<1176269612.3962.11.camel@localhost.localdomain>
	<461D9090.60808@oss.ntt.co.jp>
	<E1539E0ED7043848906A8FF995BDA57901E7BD64@m0143.s-mxs.net>
	<461ECA4E.9010101@oss.ntt.co.jp>
	<E1539E0ED7043848906A8FF995BDA57901E7BEBE@m0143.s-mxs.net>
	<19002.1176475004@sss.pgh.pa.us>
	<1176478259.3635.176.camel@silverbirch.site>
	<19755.1176479261@sss.pgh.pa.us>
	<1176480368.3635.199.camel@silverbirch.site>

"Simon Riggs" <simon@2ndquadrant.com> writes:
> Writing lots of additional code simply to remove a parameter that
> *might* be mis-interpreted doesn't sound useful to me, especially when
> bugs may leak in that way. My take is that this is simple and useful
> *and* we have it now; other ways don't yet exist, nor will they in time
> for 8.3.

The potential for misusing the switch is only one small part of the
argument; the larger part is that this has been done in the wrong way
and will cost performance unnecessarily.  The fact that it's ready
now is not something that I think should drive our choices.

I believe that it would be possible to make the needed core-server
changes in time for 8.3, and then to work on compress/decompress
on its own time scale and publish it on pgfoundry; with the hope
that it would be merged to contrib or core in 8.4.  Frankly the
compress/decompress code needs work anyway before it could be
merged (eg, I noted a distinct lack of I/O error checking).

			regards, tom lane



view thread (64+ messages)  latest in thread

Message-ID: <20249.1176483033@sss.pgh.pa.us>
Permalink:  ../20249.1176483033@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/20249.1176483033@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, simon@2ndquadrant.com, ZeugswetterA@spardat.at, suzuki.koichi@oss.ntt.co.jp, hannu@skype.net, jd@commandprompt.com, josh@agliodbs.com, pgsql-patches@postgresql.org
  Subject: Re: [HACKERS] Full page writes improvement, code update
  In-Reply-To: <20249.1176483033@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox