From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: Nikolay Shaplov <dhyan@nataraj.su>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Minor rework of ALTER TABLE SET RelOptions code
Date: Fri, 14 Mar 2025 09:35:15 +0100
Message-ID: <202503140835.a7rr73tvaeic@alvherre.pgsql> (raw)
In-Reply-To: <1913854.tdWV9SEqCh@thinkpad-pgpro>
On 2025-Mar-07, Nikolay Shaplov wrote:
> Patch description is following:
>
> 1. `isnull` variable is actually needed in a very narrow scope, so
> it is better to keep it in that scope, not keeping it in mind in while
> dealing with the rest of the code.
>
> 2. Toast table RelOptions are never altered directly with ALTER command.
> One should do ATLER to a heap relation and use toast. reloption namespace
> to address toast's reloption. If you get `ATExecSetRelOptions` called with
> `RELKIND_TOASTVALUE` relation in the args, something is really wrong. We
> should throw asserts, errors and whistle as loud as we can.
These are two separate things, I would have suggested to post them as
two separate patches. And the second one lacked tests, so I added some.
I have pushed both now, thanks.
I can't unfortunately promise to review the larger reloption refactoring
patch for 18.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Java is clearly an example of money oriented programming" (A. Stepanov)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, dhyan@nataraj.su, pgsql-hackers@lists.postgresql.org
Subject: Re: Minor rework of ALTER TABLE SET RelOptions code
In-Reply-To: <202503140835.a7rr73tvaeic@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox