From: Álvaro Herrera <alvherre@kurilemu.de>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: splitting src/bin/scripts/vacuumdb.c
Date: Fri, 26 Sep 2025 16:44:49 +0200
Message-ID: <202509261423.k3lcoxcbx5by@alvherre.pgsql> (raw)
In-Reply-To: <aNaf_YP9ruHG4Zbp@nathan>
On 2025-Sep-26, Nathan Bossart wrote:
> Seems reasonable to me.
Thanks, I had pushed this before receiving your email.
> On Fri, Sep 26, 2025 at 01:55:50PM +0200, Álvaro Herrera wrote:
> > Overall I'm quite happy with this small patch now, so I intend to push
> > shortly barring objections. I'm not adding a new commitfest entry, just
> > adding this new thread to the existing entry for REPACK. I kept the
> > patch numbering as used in the other thread.
>
> Is there any way to separate the aforementioned changes into a separate
> patch from the refactoring changes? That would make it a lot easier to
> review. I think we have decent testing for vacuumdb, so I'm not too
> concerned if this isn't feasible.
Hmm, I guess I should have posted it that way for ease of review, but
didn't think of it. You can sort-of look at the patch as
git show --color-moved=zebra
and you'll see the lines that are moved unchanged marked with one color,
and the ones that are edited in a different color. It's a bit of a
weird Christmas tree at this point, but if you look at it hard enough
you can tell the unchanged ones apart.
I had looked at the coverage of this file earlier today, and I agree
that we have pretty decent coverage -- although it's one of the two
worst-covered files in that subdirectory, the lines that aren't covered
are mostly a few error messages. It might be a good idea to add some
tests for those anyway, to ensure we don't break anything later.
Thanks!
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Y una voz del caos me habló y me dijo
"Sonríe y sé feliz, podría ser peor".
Y sonreí. Y fui feliz.
Y fue peor.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, nathandbossart@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: splitting src/bin/scripts/vacuumdb.c
In-Reply-To: <202509261423.k3lcoxcbx5by@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox