agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_createsubscriber --dry-run logging concerns
Date: Wed, 1 Oct 2025 12:37:20 +0200
Message-ID: <202510011031.6emshjc2co4s@alvherre.pgsql> (raw)
In-Reply-To: <CAHut+Pvs-nvR5A2vWCA7XtJguHP=oL3rDHjoM1pN_HP4mQdpSQ@mail.gmail.com>
On 2025-Oct-01, Peter Smith wrote:
> (code below may not work; it's just for illustrative purposes)
>
> #define pg_log_info_checkdry(...) do {\
> if (dry_run)\
> pg_log_generic(PG_LOG_INFO, PG_LOG_PRIMARY, "[dry-run NOP]" __VA_ARGS__);\
> else;\
> pg_log_generic(PG_LOG_INFO, PG_LOG_PRIMARY, __VA_ARGS__);\
> } while (0);
I like this kind of idea best. However I think it might be better to do
it the other way around: have the normal pg_log_info() check dry_run,
and have a special one for the messages that are to be identical in
either mode. I'm not sure how difficult this is to implement, though.
pg_subscriber is not the only program with a dry-run mode; it looks like
pg_archiveclean, pg_combinebackup, pg_resetwal, pg_rewind have one. Is
it worth maybe doing something at the common/logging.c level rather than
specifically pg_createsubscriber?
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
[…] indem ich in meinem Leben oft an euch gedacht, euch glücklich zu machen. Seyd es!
A menudo he pensado en vosotros, en haceros felices. ¡Sedlo, pues!
Heiligenstädter Testament, L. v. Beethoven, 1802
https://de.wikisource.org/wiki/Heiligenstädter_Testament
view thread (27+ messages) latest in thread
Message-ID: <202510011031.6emshjc2co4s@alvherre.pgsql>
Permalink: ../202510011031.6emshjc2co4s@alvherre.pgsql/
Also on: postgresql.org/message-id/202510011031.6emshjc2co4s@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, smithpb2250@gmail.com, kuroda.hayato@fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_createsubscriber --dry-run logging concerns
In-Reply-To: <202510011031.6emshjc2co4s@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox