public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Date: Wed, 22 Oct 2025 14:49:11 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAApHDvqyCEGc7taz3OiF-LMsWmUVhgmGErWR9rH+wtFU-U-JCg@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CAApHDvqyCEGc7taz3OiF-LMsWmUVhgmGErWR9rH+wtFU-U-JCg@mail.gmail.com>
> On Mon, 20 Oct 2025 at 16:59, Tatsuo Ishii <[email protected]> wrote:
>>
>> > A very trivial commit:
>> >
>> > ```
>> > + else
>> > +
>> > + /*
>> > + * For other cases we have no idea what position of row callers would
>> > + * fetch next time. Also for relpos < 0 case (we go backward), we
>> > + * cannot set mark either. For those cases we always set mark at 0.
>> > + */
>> > + mark_pos = 0;
>> > ```
>> >
>> > The empty line after “else” is not needed.
>>
>> That was added by pgindent.
>
> If it's written down somewhere, I can't find it, but the rule we
> normally follow here is; don't use braces if the code block has a
> single statement without any comments that appear on a separate line.
> Otherwise, use braces.
Oh ok, I didn't know that.
> Since your comments are not on the same line as the statement, it
> should have braces. I imagine that's why pgindent is "acting weird".
Attached is a trivial patch to follow the rule.
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
Attachments:
[application/octet-stream] v1-0001-Fix-coding-style-with-else.patch (1.3K, ../[email protected]/2-v1-0001-Fix-coding-style-with-else.patch)
download | inline diff:
From 1c17f071d825c64843e994c137cc35c076e13af9 Mon Sep 17 00:00:00 2001
From: Tatsuo Ishii <[email protected]>
Date: Wed, 22 Oct 2025 14:38:21 +0900
Subject: [PATCH v1] Fix coding style with "else".
The "else" code block having single statement with comments on a
separate line should have been surrounded by braces.
Reported-by: Chao Li <[email protected]>
Suggested-by: David Rowley <[email protected]>
Author: Tatsuo Ishii <[email protected]>
Discussion: https://postgr.es/m/20251020.125847.997839131426057290.ishii%40postgresql.org
---
src/backend/executor/nodeWindowAgg.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/backend/executor/nodeWindowAgg.c b/src/backend/executor/nodeWindowAgg.c
index 497eb25ea29..88c6bbba259 100644
--- a/src/backend/executor/nodeWindowAgg.c
+++ b/src/backend/executor/nodeWindowAgg.c
@@ -3822,13 +3822,14 @@ WinGetFuncArgInPartition(WindowObject winobj, int argno,
if (seektype == WINDOW_SEEK_CURRENT && relpos > 0)
mark_pos = winstate->currentpos;
else
-
+ {
/*
* For other cases we have no idea what position of row callers would
* fetch next time. Also for relpos < 0 case (we go backward), we
* cannot set mark either. For those cases we always set mark at 0.
*/
mark_pos = 0;
+ }
/*
* Get the next nonnull value in the partition, moving forward or backward
--
2.43.0
view thread (91+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox