public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tatsuo Ishii <[email protected]>
To: [email protected]
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Date: Thu, 23 Oct 2025 11:06:59 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAApHDvqyCEGc7taz3OiF-LMsWmUVhgmGErWR9rH+wtFU-U-JCg@mail.gmail.com>
	<[email protected]>

>> On Mon, 20 Oct 2025 at 16:59, Tatsuo Ishii <[email protected]> wrote:
>>>
>>> > A very trivial commit:
>>> >
>>> > ```
>>> > +     else
>>> > +
>>> > +             /*
>>> > +              * For other cases we have no idea what position of row callers would
>>> > +              * fetch next time. Also for relpos < 0 case (we go backward), we
>>> > +              * cannot set mark either. For those cases we always set mark at 0.
>>> > +              */
>>> > +             mark_pos = 0;
>>> > ```
>>> >
>>> > The empty line after “else” is not needed.
>>>
>>> That was added by pgindent.
>> 
>> If it's written down somewhere, I can't find it, but the rule we
>> normally follow here is; don't use braces if the code block has a
>> single statement without any comments that appear on a separate line.
>> Otherwise, use braces.
> 
> Oh ok, I didn't know that.
> 
>> Since your comments are not on the same line as the statement, it
>> should have braces. I imagine that's why pgindent is "acting weird".
> 
> Attached is a trivial patch to follow the rule.

Patch pushed. Thanks.
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

view thread (91+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox