agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>
Cc: kuroda.hayato@fujitsu.com <kuroda.hayato@fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_createsubscriber --dry-run logging concerns
Date: Tue, 4 Nov 2025 10:59:27 +0100
Message-ID: <202511040909.o6seyffn6lmo@alvherre.pgsql> (raw)
In-Reply-To: <CAHut+PtN_7iXjzODxp2kuKWpgqitgN1fqMNEgQSdXi4s3bMryg@mail.gmail.com>
On 2025-Nov-04, Peter Smith wrote:
> On Sat, Nov 1, 2025 at 5:02 AM Álvaro Herrera <alvherre@kurilemu.de> wrote:
> > I'm not opposed to 0001 (to master only), but I think the lines of
> > dashes are a little excessively noisy. Are there other opinions on
> > that? Note that vacuumlo also has it, with no dashes.
>
> It was intentionally "noisy" with dashes to make it impossible to
> accidentally overlook dry-run mode in the logs. But if that's contrary
> to the way Postgres does things I am fine if you want to remove the
> dashes.
Yeah, I don't know if it's The Postgres Way or just accidental, but I'd
rather stay away from that kind of noise. Also, from a i18n point of
view, the lines of dashes (as implemented here) would get in the message
catalogs, which nobody will appreciate. Please do make the messages a
single string rather than two separate strings though, perhaps with an
embedded newline if more than one line of output is needed.
> I took a quick look at your follow-up patches and below are some comments:
Thanks for looking at them. I pushed 0002; I'm waiting on the CI run
https://cirrus-ci.com/build/5618025065349120
to push 0001.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
view thread (27+ messages) latest in thread
Message-ID: <202511040909.o6seyffn6lmo@alvherre.pgsql>
Permalink: ../202511040909.o6seyffn6lmo@alvherre.pgsql/
Also on: postgresql.org/message-id/202511040909.o6seyffn6lmo@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, smithpb2250@gmail.com, li.evan.chao@gmail.com, euler@eulerto.com, kuroda.hayato@fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_createsubscriber --dry-run logging concerns
In-Reply-To: <202511040909.o6seyffn6lmo@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox