From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Subject: Re: Fixing pgbench's logging of transaction timestamps
Date: Mon, 02 Jan 2017 12:28:31 -0500
Message-ID: <20259.1483378111@sss.pgh.pa.us> (raw)
In-Reply-To: <18059.1483302133@sss.pgh.pa.us>
References: <8837.1483216839@sss.pgh.pa.us>
<alpine.DEB.2.20.1701011128380.15074@lancre>
<18059.1483302133@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I wrote:
> BTW, why is it that the --aggregate-interval option is unsupported on
> Windows? Is that an artifact of the same disease of assuming too much
> about how instr_time is represented? I don't see any very good reason
> for it other than the weird decision to store the result of
> INSTR_TIME_GET_DOUBLE in a "long", which seems rather broken in any case.
After looking closer, I see the real issue is that it prints the integer
part of INSTR_TIME_GET_DOUBLE and documents that as being a Unix
timestamp. So that's not going to do either. I solved it the same way
as in the other code path, ie just eat the cost of doing our own time
inquiry.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, coelho@cri.ensmp.fr
Subject: Re: Fixing pgbench's logging of transaction timestamps
In-Reply-To: <20259.1483378111@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox