public inbox for [email protected]
help / color / mirror / Atom feedFrom: Álvaro Herrera <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Some cleanup of pg_stat_statements tests
Date: Tue, 20 Jan 2026 13:36:47 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 2026-Jan-20, Michael Paquier wrote:
> While looking at this area of the code, I have noticed that the new
> "squashing" test is not consistent with the rest of the test suite,
> re-creating the extension for nothing.
>
> The structure of the test is to have the "cleanup" phase second to
> last, so as there is no need to create multiple times the extensions.
Huh, yeah, agreed on this change.
> In passing, I'd like to suggest that REGRESS in the Makefile uses one
> item per line, to minimize diffs when we add new stuff.
Absolutely.
> Any thoughts or objections about the attached?
No objections here.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Java is clearly an example of money oriented programming" (A. Stepanov)
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Some cleanup of pg_stat_statements tests
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox