public inbox for [email protected]
help / color / mirror / Atom feedFrom: Álvaro Herrera <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: trivial designated initializers
Date: Fri, 30 Jan 2026 10:28:02 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 2026-Jan-29, Peter Eisentraut wrote:
> You could spruce this up further like
>
> [LockTupleKeyShare] = {
> .hwlock = AccessShareLock,
> ...
> },
Oh right, done that way.
> The comments "/* KeyShare does not allow updating tuples */" etc. seem
> repetitive and don't actually explain why -1 is an appropriate value. You
> could instead write a comment by the declaration of the updstatus field,
> like "set to -1 if the tuple lock mode does not allow updating tuples (see
> get_mxact_status_for_lock())".
Good point. I rewrote the comment on top of the declaration and pushed,
thanks for the reviews.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Hay dos momentos en la vida de un hombre en los que no debería
especular: cuando puede permitírselo y cuando no puede" (Mark Twain)
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: trivial designated initializers
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox