From: Álvaro Herrera <alvherre@kurilemu.de>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Miscellaneous message fixes
Date: Tue, 10 Feb 2026 11:26:55 +0100
Message-ID: <202602101023.p75nm75pl7jh@alvherre.pgsql> (raw)
In-Reply-To: <20260210.143752.1113524465620875233.horikyota.ntt@gmail.com>
On 2026-Feb-10, Kyotaro Horiguchi wrote:
Hello,
> 0006:
> In extended_stats_funcs.c:
> > errmsg("could not find extended statistics object \"%s\".\"%s\"",
> > quote_identifier(nspname),
> > quote_identifier(stxname)));
>
> Since quote_identifier() already adds quoting when needed, adding
> "%s"."%s" in the format string results in double quoting. It would be
> better to use %s.%s instead. I think quoting should be applied only
> when necessary here. I'm not sure we should use
> quote_qualified_identifier() instead.. (It's not used in the attached
> patch).
>
> There's a similar inconsistency.
>
> > errmsg("could not clear extended statistics object \"%s\".\"%s\": incorrect relation \"%s\".\"%s\" specified",
> > get_namespace_name(nspoid), stxname,
> > relnspname, relname));
>
> In this part, the names are not passed through quote_identifier(). It
> would be better to unify this as well.
Hmm, in the vast majority of messages, the quotes are in the literal
string, and we do not add quote_identifier(). This way, the names are
always quoted, not just when they are funny identifiers; also the
translator chooses the quoting style they want, which is not necessarily
the same as the one used in English.
So my recommendation would be to remove the quote_identifier() calls and
leave the quotes in the message.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Miscellaneous message fixes
In-Reply-To: <202602101023.p75nm75pl7jh@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox