pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feed[PATCH] Remove trailing period from errmsg in subscriptioncmds.c
3+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2026-03-09 06d8302262 Remove trailing period from errmsg in subscriptioncmds.c.
* [PATCH] Remove trailing period from errmsg in subscriptioncmds.c
@ 2026-03-08 14:28 Sahitya Chandra <sahityajb@gmail.com>
0 siblings, 2 replies; 3+ messages in thread
From: Sahitya Chandra @ 2026-03-08 14:28 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org; +Cc: Sahitya Chandra <sahityajb@gmail.com>
Hi,
While reading the subscription code I noticed one error message that doesn't follow the project's style: in check_remote_recovery_state() in subscriptioncmds.c, the errmsg() for the "publisher is in recovery" case ends with a period. The convention elsewhere (including the similar message a few lines above in the same file) is no trailing period.
The attached one-line patch removes the trailing period from that string. No behavior change.
Thanks,
Sahitya Chandra
---
src/backend/commands/subscriptioncmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
inline patch 1: src/backend/commands/subscriptioncmds.c (+1/-1 lines) download inline-1.patch
diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c
index 9e21d7a7df9..724637cff5b 100644
--- a/src/backend/commands/subscriptioncmds.c
+++ b/src/backend/commands/subscriptioncmds.c
@@ -2993,7 +2993,7 @@ check_pub_dead_tuple_retention(WalReceiverConn *wrconn)
if (remote_in_recovery)
ereport(ERROR,
errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
- errmsg("cannot enable retain_dead_tuples if the publisher is in recovery."));
+ errmsg("cannot enable retain_dead_tuples if the publisher is in recovery"));
ExecDropSingleTupleTableSlot(slot);
--
2.43.0
* Re: [PATCH] Remove trailing period from errmsg in subscriptioncmds.c
@ 2026-03-09 07:45 Amit Kapila <amit.kapila16@gmail.com>
parent: Sahitya Chandra <sahityajb@gmail.com>
1 sibling, 0 replies; 3+ messages in thread
From: Amit Kapila @ 2026-03-09 07:45 UTC (permalink / raw)
To: Sahitya Chandra <sahityajb@gmail.com>; +Cc: pgsql-hackers@lists.postgresql.org
On Sun, Mar 8, 2026 at 7:58 PM Sahitya Chandra <sahityajb@gmail.com> wrote:
>
> While reading the subscription code I noticed one error message that doesn't follow the project's style: in check_remote_recovery_state() in subscriptioncmds.c, the errmsg() for the "publisher is in recovery" case ends with a period. The convention elsewhere (including the similar message a few lines above in the same file) is no trailing period.
>
> The attached one-line patch removes the trailing period from that string. No behavior change.
>
LGTM.
--
With Regards,
Amit Kapila.
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH] Remove trailing period from errmsg in subscriptioncmds.c
@ 2026-03-09 08:51 yangyz <1197620467@qq.com>
parent: Sahitya Chandra <sahityajb@gmail.com>
1 sibling, 0 replies; 3+ messages in thread
From: yangyz @ 2026-03-09 08:51 UTC (permalink / raw)
To: Sahitya Chandra <sahityajb@gmail.com>; pgsql-hackers <pgsql-hackers@lists.postgresql.org>; +Cc: Sahitya Chandra <sahityajb@gmail.com>
LGTM, according to https://www.postgresql.org/docs/18/error-style-guide.html
Primary error messages: Do not capitalize the first letter. Do not end a message with a period. Do not even think about ending a message with an exclamation point.
regards，
Yuanzhuo Yang
Original
From: Sahitya Chandra <sahityajb@gmail.com>
Date: 2026-03-08 22:28
To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Cc: Sahitya Chandra <sahityajb@gmail.com>
Subject: [PATCH] Remove trailing period from errmsg in subscriptioncmds.c
Hi,
While reading the subscription code I noticed one error message that doesn't follow the project's style: in check_remote_recovery_state() in subscriptioncmds.c, the errmsg() for the "publisher is in recovery" case ends with a period. The convention elsewhere (including the similar message a few lines above in the same file) is no trailing period.
The attached one-line patch removes the trailing period from that string. No behavior change.
Thanks,
Sahitya Chandra
---
src/backend/commands/subscriptioncmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
inline patch 1: src/backend/commands/subscriptioncmds.c (+1/-1 lines) download inline-1.patch
diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c
index 9e21d7a7df9..724637cff5b 100644
--- a/src/backend/commands/subscriptioncmds.c
+++ b/src/backend/commands/subscriptioncmds.c
@@ -2993,7 +2993,7 @@ check_pub_dead_tuple_retention(WalReceiverConn *wrconn)
if (remote_in_recovery)
ereport(ERROR,
errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
- errmsg("cannot enable retain_dead_tuples if the publisher is in recovery."));
+ errmsg("cannot enable retain_dead_tuples if the publisher is in recovery"));
ExecDropSingleTupleTableSlot(slot);
--
2.43.0
end of thread, other threads:[~2026-03-09 08:51 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-03-08 14:28 [PATCH] Remove trailing period from errmsg in subscriptioncmds.c Sahitya Chandra <sahityajb@gmail.com>
2026-03-09 07:45 ` Amit Kapila <amit.kapila16@gmail.com>
2026-03-09 08:51 ` yangyz <1197620467@qq.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox